CJK overflow - update to match gl-shader

[amyleew]

Per #5873 (comment), working on updates to match mapbox/mapbox-gl-shaders#22 and mapbox/mapbox-gl-js#2930.

/cc @lbud @xrwang

[amyleew]

Looking good in Xcode! @brunoabinader can you take a final 👀

[friedbunny]

When it comes time to merge this, please squash and prefix the commit with [core].

[lucaswoj]

The only shaders with a a_data1 attribute were icon and sdf. Because this PR removes that attribute in both cases, we need to make changes everywhere in the codebase that a_data1 and a_data2 are referenced.

• src/mbgl/shader/icon_shader.cpp
• src/mbgl/shader/sdf_shader.cpp
• src/mbgl/geometry/collision_box_buffer.cpp
• src/mbgl/geometry/icon_buffer.cpp
• src/mbgl/geometry/text_buffer.cpp
• src/mbgl/shader/shader.hpp
• src/mbgl/shader/shader.cpp

Until all these are changed, I would expect segfaults, rendering errors, and compilation errors.

[amyleew]

Finally we got green 🍏 ✅ @lucaswoj @xrwang @jakepruitt !!!

Can't wait to first thing tomorrow

[1ec5]

/ref #5873 #1681

[lucaswoj]

Was this ready to merge? I don't see a PR review from any GL Native core contributors or #5908 (comment) having been addressed.

[amyleew]

Perhaps I misunderstood the PR review. Also I pushed squash and commit with the commit. #5873 was taken care off, thought #1681 was a GL native bug to fix seperately since this was happening with the original sized atlas as well.

[1ec5]

#1681 is the original ticket tracking CJK glyph overflow issues.