-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
@mourner, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jfirebaugh, @yhahn and @boundsj to be potential reviewers |
OK, clustering now seems to be working! |
|
||
namespace mbgl { | ||
|
||
class GeoJSON { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this header file and keep using the GeoJSON
symbol, but change the definition to:
namespace mbgl {
using GeoJSON = mapbox::geojson::geojson;
} // namespace mbgl
This follows a convention established by mbgl::Geometry
, mbgl::Feature
, etc. It keeps the naming conventions within the project more consistent, and allows for definition changes (like this one) to happen with minimal changes to downstream code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will do.
The tests passed, woohoo! Now what's left is rebase + cleanup + merge. |
@@ -1705,6 +1705,7 @@ | |||
"$(OTHER_CFLAGS)", | |||
"$(variant_cflags)", | |||
"$(geometry_cflags)", | |||
"$(geojson_cflags)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be corresponding changes in macos.xcodeproj?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe — let me add them. I wonder why it's not caught by the builds though.
[skip ci]
Any idea when this will make it into the iOS SDK release? |
@leekuo, this functionality is now in ios-v3.4.0-alpha.1. Please note the caveats in #320 (comment). |
Closes #320, a work in progress. cc @jfirebaugh
Supercluster
type tourlOrGeoJSON
variantGeoJSONSource::Impl
setGeoJSON
ifcluster
istrue
in options and use it increateTile
see if we can avoid addinggeojson
to include paths and public headers[core]
prefix to commits