This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[Qt] Implement the runtime style API #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpsantos
force-pushed
the
tmpsantos-qt_style_api
branch
2 times, most recently
from
d75268c to
9dfac3b
Compare
| @@ -174,6 +174,8 @@ class Q_DECL_EXPORT QMapboxGL : public QObject | |||
|
|
|||
| void removeAnnotation(QMapbox::AnnotationID); | |||
|
|
|||
| void setLayoutProperty(const QString& layer, const QString& property, const QVariant& value); | |||
There was a problem hiding this comment.
Let's use the Qt style on the header files e.g. put the & together with the param name.
|
Minor comments above, but this is awesome! 🎉 |
clang finds this construction ambiguous, go figure.
QByteArray::data() may do a deep copy.
tmpsantos
force-pushed
the
tmpsantos-qt_style_api
branch
from
9dfac3b to
462137a
Compare
|
|
||
| // Needed to keep the error message alive | ||
| // when we go out of this scope. | ||
| static std::string error; |
There was a problem hiding this comment.
Can you open a ticket to change Error so we can remove this?
This was referenced Jul 12, 2016
Closed
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5551, but using the core datatype converters.