-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[core] Refactor wireframe to match JS overdraw #5403
Conversation
9979db1
to
209f8ed
Compare
I suspect the |
c1d25d4
to
456368d
Compare
Awesome! |
456368d
to
6c9e00b
Compare
I initially thought this would be good to cherry-pick into the |
wireframe effect. */ | ||
MGLMapDebugWireframesMask = 1 << 5, | ||
/** Overdraw inspector. */ | ||
MGLMapDebugOverdrawsMask = 1 << 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enum value needs a more descriptive name, and the comment is somewhat nonsensical to an iOS developer.
@friedbunny, @brunoabinader renamed the public enum value, so we either need to revert the Objective-C changes or backport them to the release branch. Otherwise, the release after 3.3.0 will break backwards compatibility. |
@1ec5 I suppose just porting the Obj-C changes without including the refactored implementation itself is a thing we can do. Functionality would change after v3.3.0, but the API would remain the same. |
This PR:
BlendColor
GL configuration valueFixes #5371.
Snapshot:

Notes:
Wireframe
andOverdraw
serves different purposes - we could add a new debug mode instead of replacingwireframe
implementation.👀 @mapbox/gl