Fix static framework packaging

[friedbunny]

Fixes #5071, where make ipackage would produce a static framework that did not include our Objective-C symbols.

• Adds libMapbox.a to the libtool binary conglomeration step for the static framework.
• Simulator debug builds now include x86_64 slices (by setting ONLY_ACTIVE_ARCH=NO).
• Per 9732f02 (More Makefile cleanup #5120), the default build type is now debug for make ipackage-foo.
  • The deploy script has been updated to explicitly build for release.
  • For manual release builds, run make ipackage-foo BUILDTYPE=Release.

/cc @1ec5 @boundsj

[1ec5]

👍

[friedbunny]

@1ec5 reminded me that I should mention a weird issue I encountered while trying to use libtool to smoosh together the constituent libraries: When the simulator libraries did not include an x86_64 slice (because BUILDTYPE=Debug defaults to ONLY_ACTIVE_ARCH=YES), the resulting file from libtool would only include the contents of libgeojsonvt.a.

I don’t understand why, but libtool became able to combine all of the constituent libraries once I set ONLY_ACTIVE_ARCH=NO.

[friedbunny]

Another note, with a hat-tip to @1ec5: otool -L and lipo -info are very useful for identifying which classes/sub-libraries and architectures a library has (respectively).

$ otool -L build/ios/pkg/static/Mapbox.framework/Mapbox
Archive : build/ios/pkg/static/Mapbox.framework/Mapbox
build/ios/pkg/static/Mapbox.framework/Mapbox(MGLPointAnnotation.o):
build/ios/pkg/static/Mapbox.framework/Mapbox(MGLFeature.o):
... and so on...
build/ios/pkg/static/Mapbox.framework/Mapbox(tile.o):
build/ios/pkg/static/Mapbox.framework/Mapbox(wrap.o):

$ lipo -info build/ios/pkg/static/Mapbox.framework/Mapbox
Architectures in the fat file: build/ios/pkg/static/Mapbox.framework/Mapbox are: armv7 arm64 i386 x86_64 armv7s 

[1ec5]

We should revisit whether this flag is necessary after mapbox/mason#181 lands. Ideally we’d stick to just the standard architectures, to minimize the build size.