This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make custom callout views easier to use [WIP] #4948
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ee85e7d
[ios] Replace SMCalloutView with custom callout
friedbunny ffc2ffb
Change callout body color to white, text to tint color
friedbunny a7fb417
Fix occasional gap between callout body and tip
friedbunny 239c5fb
Remove MGLCalloutDelegate, add properties on MGLAnnotation
friedbunny deb681b
Custom callout views, but must conform to protocol
friedbunny fa27c4f
Fix OS X build by actually excluding UIKit
friedbunny 8dc99e6
Remove unnecessary background color method
friedbunny 833a0a2
Limit callouts to point annotations
friedbunny 042d720
Make callout properties iPhone-specific, fix OS X build again
friedbunny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come to think of it, these view-related properties don’t belong in a model protocol if we’re going to respect a conventional MVC pattern. MapKit places this and other callout-related properties on MKAnnotationView, which prevents the developer from customizing the callout view for custom model objects that are used as point annotations. Once #4801 lands, it may be worth moving these properties over to MGLAnnotationView.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where these properties live will need to be reevaluated after #4801, aye. Though, if callouts only existed on
MGLAnnotationView
, wouldn’t GL (e.g.,MGLPointAnnotation
MGLAnnotationImage
) annotations not have (custom) callouts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. Maybe we should put them in a separate protocol, MGLCalloutSource, that both MGLPointAnnotation and MGLAnnotationImage could conform to.