This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Wireframe debug mode #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoabinader
added
the
performance
brunoabinader
added a commit
that referenced
this pull request
May 21, 2016
Together with MapDebugOptions::Collision, provides "wireframe" rendering output so all drawn objects are visible. This mode ignores the line width, background and fill colors for better visualization. Fixes #4359.
|
Example output:
|
|
@1ec5 I think this is what @kkaefer mentioned - https://github.com/mapbox/mapbox-gl-native/blob/master/platform/default/glfw_view.cpp#L483-L520 - which provides a different output - but can be added as a new |
|
22ef615f360bb5e0ea58491620f0fc59da8f491b exposes this new mode in the iOS and OS X SDKs and their demo applications. |
|
Thank you @1ec5! |
Together with MapDebugOptions::Collision, provides "wireframe" rendering output so all drawn objects are visible. This mode ignores the line width, background and fill colors for better visualization. Fixes #4359.
Added an option to MGLMapDebugMaskOptions for the new wireframe debugging mode and UI in the demo applications for toggling it.
brunoabinader
force-pushed
the
brunoabinader-wireframe
branch
from
22ef615 to
2865e7d
Compare
|
@brunoabinader stencil mask mode is different from the wireframe mode; the stencil mode shows the checkerboard-style pattern that we're using to clip tiles. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with
MapDebugOptions::Collision, provides wireframe rendering output so all drawn objects are visible. This mode ignores the line width, background and fill colors for better visualization./cc @mapbox/gl