This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[core] Add client defined network status #4234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpsantos
force-pushed
the
tmpsantos-offline_mode
branch
from
303ff0c to
81b8fc1
Compare
|
No (more) timing-based tests, please. Please figure out how to write the test without using timers. |
This API will let the client force a network status. If set to Offline, we won't make network requests. When set make to Online, it will trigger the pending requests and try to fetch tiles from the network.
Use the newly added NetworkStatus::Set().
The user can now force the Offline mode and set it back to Online, triggering the requests waiting for network connection.
👍 This one just needs to make sure that the request only gets answered after setting NetworkStatus back to Online. |
tmpsantos
force-pushed
the
tmpsantos-offline_mode
branch
from
81b8fc1 to
fc805dd
Compare
|
Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API will let the client force a network status. If set to Offline, we won't make network requests.
When set make to Online, it will trigger the pending requests and try to fetch tiles from the network.