This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Invalidate CADisplayLink #3448
Merged
Invalidate CADisplayLink #3448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
bug
iOS
This was referenced Jan 6, 2016
Closed
1ec5
force-pushed
the
1ec5-unlink-display-3130
branch
from
f8916c4 to
f35db42
Compare
CADisplayLink holds a strong reference to its target, forming a cycle that must be broken with -[CADisplayLink invalidate] when the animation is complete. I don’t yet have enough faith that will-change and did-change notifications are always coming from mbgl in pairs, so this change limits CADisplayLink to when MGLMapView is in the view hierarchy. It also pauses the CADisplayLink when the view is hidden or the application is in the background. Finally, -[MGLMapView invalidate] has been renamed because that term tends not to mean “redraw” in Cocoa but is rather tied to timers. Fixes #3130. [ios] Also invalidate CADisplayLink on removal from window [ios] Also shut down CADisplayLink when view is hidden
1ec5
force-pushed
the
1ec5-unlink-display-3130
branch
from
c610a7e to
6fcb9f4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CADisplayLink holds a strong reference to its target, forming a cycle that must be broken with
-[CADisplayLink invalidate]when the animation is complete. I don’t yet have enough faith thatMapChangeRegionWillChangeAnimatedandMapChangeRegionDidChangeAnimatednotifications are always coming from mbgl in pairs, so this change limits CADisplayLink to when MGLMapView is in the view hierarchy. It also pauses the CADisplayLink when the application is in the background. Finally,-[MGLMapView invalidate]has been renamed because that term tends not to mean “redraw” in Cocoa but is rather tied to timers.Fixes #3130, which is a regression introduced in #2922.
@adam-mapbox @tomtaylor, can you verify that the original fix has not regressed with this change?