Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

initial featuresAt implementation #3172

Closed
wants to merge 64 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
139b9e7
refs #352: catalog (hardcoded: POI) features on tile parse
incanus Nov 25, 2015
b1ad1b6
fix crasher
incanus Nov 26, 2015
8a4f068
refs #352: current state of feature querying
incanus Nov 26, 2015
5de3f99
refs #352: remove unused forward declaration
incanus Nov 26, 2015
3f89f50
refs #352: parse interactive layer property from style
incanus Nov 26, 2015
e4f1339
refs #352: further work on featuresAt
incanus Dec 1, 2015
32cb432
refs #352: debug tap coordinate & fix y flip for core
incanus Dec 1, 2015
e309fe3
refs #352: remove logging
incanus Dec 1, 2015
7515847
refs #352: hook up `name_en` & normal radius (works for <=z15!)
incanus Dec 1, 2015
dc4f5fa
refs #352: naively fetch all feature properties upfront for now
incanus Dec 1, 2015
454c014
refs #352: clean up adds
incanus Dec 1, 2015
8fd4eaf
refs #352: better debug logging
incanus Dec 1, 2015
bda6e0c
refs #352: only query clicked tile
incanus Dec 1, 2015
cd15d85
refs #352: properly query scale
incanus Dec 1, 2015
29dc55e
refs #352: clean out existing tile feature tree on any sort of re-parse
incanus Dec 2, 2015
b1e3da9
refs #352: fix for overzoomed tiles & disable some debug logs
incanus Dec 2, 2015
d0a34c5
refs #352: pipe source through the features query
incanus Dec 2, 2015
f8fb791
refs #352: typedef feature results for brevity
incanus Dec 2, 2015
caa2576
refs #352: naive plumbing of work down into source
incanus Dec 2, 2015
fdfb377
refs #352: commenting cleanup
incanus Dec 2, 2015
41159cb
refs #352: public interface cleanup & get rid of unneeded optional/va…
incanus Dec 2, 2015
fd4b063
refs #352: cleanups
incanus Dec 2, 2015
181a997
refs #352: add comment
incanus Dec 2, 2015
641e7db
refs #352: move result feature tree directly
incanus Dec 2, 2015
ac6ada3
refs #352: clean up extent handling & only add features when valid bbox
incanus Dec 3, 2015
7cdcc49
refs #352: obtain non-string vector tile properties as well
incanus Dec 3, 2015
b5f5a24
refs #352: sort result keys at query time as on JS
incanus Dec 3, 2015
a9b9568
refs #352: clarify comment
incanus Dec 3, 2015
e7b01cd
refs #352: don't clobber debug output properties each loop
incanus Dec 3, 2015
d5c31e2
refs #352: fix partial parse symbol layers
incanus Dec 3, 2015
660ff91
refs #352: remove debug log
incanus Dec 3, 2015
22e5c48
refs #352: remove logging & reorganize
incanus Dec 3, 2015
7f6010a
refs #352: build up Cocoa API and remove last of logging
incanus Dec 3, 2015
9824937
refs #352: add Cocoa docs
incanus Dec 3, 2015
91976cb
refs #352: add gesture for feature querying
incanus Dec 3, 2015
2c266e3
refs #352: added interactive style mode to iOS test app
incanus Dec 3, 2015
00339ac
refs #352: removed more extraneous debug stuff
incanus Dec 3, 2015
2a1f0e6
refs #352: pipe through a radius parameter and use 50 on mobile
incanus Dec 3, 2015
0e05c3e
refs #352: add legit iOS feature querying mode
incanus Dec 3, 2015
72ef933
refs #352: return all properties for annotation tiles
incanus Dec 3, 2015
b9f47f8
refs #352: move away from interrupting alert
incanus Dec 3, 2015
42741cd
refs #352: remove last debug note
incanus Dec 3, 2015
f91df07
refs #352: use actual source max zoom
incanus Dec 3, 2015
0b6953e
refs #352: scroll text area to top when changing contents
incanus Dec 3, 2015
392acd9
refs #352: be more explicit about numeric types and fix tests(?)
incanus Dec 3, 2015
1320df7
refs #352: finally fix tests on Linux by being explicit about numeric…
incanus Dec 3, 2015
0ea4f53
more descriptive & safer public API
incanus Dec 14, 2015
b98b686
use defined type
incanus Dec 14, 2015
4c639e5
abstract tile extent 4096 variable
incanus Dec 14, 2015
6c86e78
interactive -> isInteractive
incanus Dec 14, 2015
262665e
boxed literals for UTF8 strings
incanus Dec 14, 2015
beda70d
fix bug with storing to reference
incanus Dec 14, 2015
505f929
better, stronger types & more clear method names
incanus Dec 14, 2015
b6ad5e2
fix camel case for local variables
incanus Dec 14, 2015
d123545
radius uint8_t -> uint16_t as with height & width
incanus Dec 14, 2015
ac655ce
better comments, abstract extent, and don't iterate over all loaded t…
incanus Dec 14, 2015
394c484
expose feature query radius in MGLMapView API
incanus Dec 14, 2015
10d36f8
refer to screen points in public API
incanus Dec 14, 2015
6b72663
Merge remote-tracking branch 'origin/master' into 352-featuresAt
incanus Dec 14, 2015
d088794
layer is now a pointer
incanus Dec 14, 2015
a04b13e
fix getAllValues() for new GeoJSON feature type
incanus Dec 14, 2015
7f07974
getAllValues() -> getValues()
incanus Dec 14, 2015
30239c2
fix Linux narrow warning by using correct type
incanus Dec 14, 2015
02ea849
more POI layers in demo, but cleaner output visually
incanus Dec 15, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refs #352: clarify comment
incanus committed Dec 3, 2015
commit a9b9568b0c16bbfaaa3ee7cd4e475221d30b0619
2 changes: 1 addition & 1 deletion src/mbgl/map/tile_worker.cpp
Original file line number Diff line number Diff line change
@@ -168,7 +168,7 @@ void TileWorker::parseLayer(const StyleLayer& layer, const GeometryTile& geometr

if (featureBox.min_corner().get<0>() < 4096 && featureBox.min_corner().get<1>() < 4096 &&
featureBox.max_corner().get<0>() > -1 && featureBox.max_corner().get<1>() > -1) {
// TODO: do this opportunistically
// TODO: opportunistically hit the pbf at query time
FeatureProperties properties;
const auto& values = feature->getAllValues();
properties.insert(values.begin(), values.end());