[android] Bring back OkHTTP

[ljbade]

Fixes #2856

[ljbade]

@bleege @tobrun Can you give this branch a good stress test. Specifically looking to reproduce #2400

[tobrun]

Crash with:

pid: 6260, tid: 8632, name: OkHttp https:// >>> com.mapbox.mapboxgl.testapp <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x3c

Full stacktrace

[tobrun]

Crash with:

Fatal signal 11 (SIGSEGV), code 1, fault addr 0x3c in tid 9178 (nJ_UO_MMZKFEaiA)

Full stacktrace

Update: I'm able to reproduce this crash constantly by following these steps:

• open a feature activity
• scroll heavily
• return to MainActivity before loading stops

[ljbade]

Thanks @tobrun was able to repro it easily.

Here is the ndk-stack log:

********** Crash dump: **********
Build fingerprint: 'samsung/zerofltedv/zeroflte:5.1.1/LMY47X/G920IDVU3DOJ6:user/release-keys'
pid: 14778, tid: 15013, name: OkHttp https://  >>> com.mapbox.mapboxgl.testapp <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x3c
Stack frame #00 pc 00360cf8  /data/app/com.mapbox.mapboxgl.testapp-2/lib/arm/libmapbox-gl.so (uv_async_send+8): Routine uv_async_send at /home/travis/build/mapbox/mason/mason_packages/.build/libuv-1.7.5/src/unix/async.c:62
Stack frame #01 pc 00205868  /data/app/com.mapbox.mapboxgl.testapp-2/lib/arm/libmapbox-gl.so (mbgl::HTTPAndroidRequest::onResponse(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::_: Routine uv::async::send() at /home/leith/mb/mapbox-gl-native/build/android-arm-v7/../../src/mbgl/util/uv_detail.hpp:124
Stack frame #02 pc 002033e0  /data/app/com.mapbox.mapboxgl.testapp-2/lib/arm/libmapbox-gl.so (mbgl::nativeOnResponse(_JNIEnv*, _jobject*, long long, int, _jstring*, _jstring*, _jstring*, _jstring*, _jstring*, _jbyteArray*)+1620): Routine mbgl::nativeOnResponse(_JNIEnv*, _jobject*, long long, int, _jstring*, _jstring*, _jstring*, _jstring*, _jstring*, _jbyteArray*) at /home/leith/mb/mapbox-gl-native/build/android-arm-v7/../../platform/android/http_request_android.cpp:359 (discriminator 6)
Stack frame #03 pc 002798b7  /data/dalvik-cache/arm/data@[email protected]@[email protected]

[ljbade]

Looks like we still have #2400

[zugaldia]

I can still reproduce the crash as @tobrun describes here: #2857 (comment)

Anecdotally, monkey fails to create a crash no matter how many times I try (adb shell monkey -p com.mapbox.mapboxgl.testapp -v 1000)

[tobrun]

@zugaldia is monkey able to scroll/zoom/pan?
To make it easier to crash: Maybe start with an already zoomed in map? The problem occurs with fetching data, if you are on highest zoomlevel and pan you won't fetch any data.

[ljbade]

Hmm monkey, going to have to look that one up.

@zugaldia did you see the PR #2905

[zugaldia]

@tobrun I believe so. It's what monkey calls a "motion event" (motion events consist of a down event somewhere on the screen, a series of pseudo-random movements, and an up event). You can add more with the --pct-motion <percent> flag.

@ljbade On it. Also, you can just start with a plain adb shell monkey -p com.mapbox.mapboxgl.testapp -v 1000.

[ljbade]

Closing as this was replaced by #2857