This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Polymorphic layout and paint parsing #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
style-api
branch
2 times, most recently
from
4105ded to
82a0e44
Compare
|
Awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fourth in a series of PRs that builds towards a full-fledged programmatic style API. This is a big chunk of work, but I'm trying to break it up step by step and not create a long-lived branch with a lot of changes.
This episode moves further towards being able to remove the generic
ClassPropertiesin favor of concrete paint and layout classes like those found in style_properties.hpp. The way that I'm going to do that is to continue refactoring until all usage ofClassPropertiesis in layer subclasses, and then substitute the concrete per-layer replacements.Specifically, the code that needs to move to layer subclasses is layout and paint parsing (this PR) and bucket creation (next PR).
👀 @kkaefer @brunoabinader