This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] fixes #2490: add annotation image enabled property #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incanus
added
feature
iOS
incanus
force-pushed
the
2490-ios-annotation-enabled
branch
from
6c0c3f5 to
cd88fe2
Compare
incanus
force-pushed
the
2490-ios-annotation-enabled
branch
from
a03eac3 to
8cc3b12
Compare
incanus
removed
the
⚠️ DO NOT MERGE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs UI tests, but does the job. Not the most efficient thing in the world, but fortunately gesture events aren't much slower. Takes about 10ms for even 10,000 annotations to figure out enabled/disabled status.
/cc @friedbunny