Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Go dormant before termination #1805

Merged
merged 1 commit into from
Jul 1, 2015
Merged

Go dormant before termination #1805

merged 1 commit into from
Jul 1, 2015

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jun 30, 2015

This is a speculative fix for #1460, #1509, and #1680 per #1460 (comment), building off the work in #1451. Once we get UIApplicationWillTerminateNotification, it’s unlikely that there will be any need to service further requests for rendering, programmatic viewport manipulation, or gesture recognition.

I’ll keep an eye on our HockeyApp stats to see if #1460 goes away at least.

/cc @incanus @friedbunny

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS crash labels Jun 30, 2015
@1ec5 1ec5 self-assigned this Jun 30, 2015
@1ec5 1ec5 added this to the iOS Beta 3 milestone Jun 30, 2015
@1ec5
Copy link
Contributor Author

1ec5 commented Jun 30, 2015

@picciano @mb12 @robipresotto, feel free to take these changes for a spin. Hopefully we can get these mystery crashes to stop mucking up everyone’s analytics! 👊→🌳

@mb12
Copy link

mb12 commented Jun 30, 2015

#1509 consistently reproducible. I have added steps to reproduce it in the issue itself.

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 1, 2015

@mb12, ah, that’s the alpha transparency one. Got a little ahead of myself.

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 2, 2015

Another attempt in #1821.

@incanus
Copy link
Contributor

incanus commented Jul 4, 2015

Should we roll this back just to simplify a bit?

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 4, 2015

@incanus, I think handling will-terminate is correct but possibly unnecessary. If you think it’ll simplify the code (less redundancy), we can roll this bug. But let’s wait until #1821 shakes out before adding another variable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crash iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants