This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Add Renderer::clearData() instead of keepRenderData map options #16323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…options `Renderer::clearData()` is a better API than the removed `MapOptions::keepRenderData()`: - gives more flexibility to the client - similar to the existing `Renderer::reduceMemoryUse()` - the `MapOptions::keepRenderData()` API implementation could not handle the raise condition, which happened if the new still image request had come before all tiles from the previous requests were loaded. Co-authored-by: Dane Springmeyer <[email protected]>
pozdnyakov
requested review from
alexshalamov,
tmpsantos and
springmeyer
and removed request for
alexshalamov
springmeyer
approved these changes
Mar 19, 2020
| @@ -2,8 +2,8 @@ | |||
| "network": [ | |||
| [ | |||
| "probeNetwork - default - end", | |||
| 12, | |||
| 340753 | |||
| 8, | |||
There was a problem hiding this comment.
I'm curious: why did these change with this PR? I would have though that this PR would not change any results and it would only fix a rare race (that I presume was not previously impacting the baselines).
|
Tested this fully downstream and everything is working well 👍 |
pozdnyakov
force-pushed
the
mikhail_renderer_clear_data
branch
from
af8d4a1 to
c08fcde
Compare
alexshalamov
approved these changes
Mar 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renderer::clearData()is a better API than the removedMapOptions::keepRenderData():Renderer::reduceMemoryUse()MapOptions::keepRenderData()API implementation could not handle the race condition, whichhappened if the new still image request had come before all tiles from the previous requests were loaded.
Co-authored-by: Dane Springmeyer [email protected]
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/215