Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Support line within polygon in within expression #16220

Merged
merged 8 commits into from
Feb 21, 2020

Conversation

zmiao
Copy link
Contributor

@zmiao zmiao commented Feb 19, 2020

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • apply needs changelog label if a changelog is needed (remove label when added)

This pr will enable using within expression with features that contain LineString geometry type.

Fix: https://github.com/mapbox/mapbox-gl-native-team/issues/188

@zmiao zmiao force-pushed the zmiao-line-within-polygon branch 3 times, most recently from d30174e to 8a9df2e Compare February 19, 2020 10:03
@zmiao zmiao self-assigned this Feb 19, 2020
@zmiao zmiao added the needs changelog Indicates PR needs a changelog entry prior to merging. label Feb 19, 2020
@zmiao zmiao force-pushed the zmiao-line-within-polygon branch from 9c4ee07 to f42e3d6 Compare February 19, 2020 10:11
@zmiao zmiao marked this pull request as ready for review February 19, 2020 10:13
@zmiao zmiao force-pushed the zmiao-line-within-polygon branch 2 times, most recently from d33f01a to b5c386a Compare February 19, 2020 11:50
@zmiao zmiao force-pushed the zmiao-line-within-polygon branch from b5c386a to 83d653b Compare February 19, 2020 11:57
src/mbgl/style/expression/within.cpp Outdated Show resolved Hide resolved
@zmiao zmiao force-pushed the zmiao-line-within-polygon branch from 6e0139c to 30ce0bd Compare February 19, 2020 18:49
@zmiao zmiao force-pushed the zmiao-line-within-polygon branch 3 times, most recently from 304d9eb to 4d99434 Compare February 20, 2020 15:55
@zmiao zmiao force-pushed the zmiao-line-within-polygon branch from 4d99434 to 15cd48e Compare February 21, 2020 08:39
@zmiao zmiao merged commit 5fcc6cf into master Feb 21, 2020
@zmiao zmiao deleted the zmiao-line-within-polygon branch February 21, 2020 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs changelog Indicates PR needs a changelog entry prior to merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants