Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Loading images to style optimization #16187

Merged
merged 5 commits into from
Feb 11, 2020

Conversation

pozdnyakov
Copy link
Contributor

This change enables attaching images to the style with batches and avoids massive re-allocations. Thus, it improves UI performance especially at start-up time.

Tag https://github.com/mapbox/mapbox-gl-native-team/issues/169

@pozdnyakov pozdnyakov added performance Speed, stability, CPU usage, memory usage, or power usage Core The cross-platform C++ core, aka mbgl labels Feb 11, 2020
@pozdnyakov pozdnyakov force-pushed the mikhail_style_images_optimization branch 4 times, most recently from 013bd3f to dc136ce Compare February 11, 2020 08:17
@pozdnyakov pozdnyakov force-pushed the mikhail_style_images_optimization branch from dc136ce to 7758ff0 Compare February 11, 2020 09:34
@pozdnyakov pozdnyakov marked this pull request as ready for review February 11, 2020 10:22
@pozdnyakov pozdnyakov requested a review from 1ec5 as a code owner February 11, 2020 10:22
This change enables attaching images to the style with batches and
avoids massive re-allocations. Thus, it improves UI performance
especially at start-up time.
@pozdnyakov pozdnyakov force-pushed the mikhail_style_images_optimization branch from 4db780d to ca065a1 Compare February 11, 2020 10:34
@pozdnyakov pozdnyakov self-assigned this Feb 11, 2020
Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ios-render-test-runner failed for some reason, I re-run the job, let's see if it fails again.

@pozdnyakov pozdnyakov merged commit 98f99e0 into master Feb 11, 2020
@pozdnyakov pozdnyakov deleted the mikhail_style_images_optimization branch February 11, 2020 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants