This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] stable position of labels at tile borders in tile mode #16040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
added
Core
|
Can be merged only after ✔️ from @mapbox/static-apis |
There was a problem hiding this comment.
Few nits.
@pozdnyakov sorting along edge border will give 'border' symbols preferential placement, thus, rendering result might look unnatural, e.g., swarming along edges, other than that, PR looks fine.
rmrice
approved these changes
Dec 20, 2019
pozdnyakov
removed
the
⚠️ DO NOT MERGE
|
Found few errors (visible after we've #16068 in place) will apply fix to this PR shortly. |
|
Hooray for the new test runner! 😁 |
In tile mode, stick to the first variable anchor if the label intersects tile borders.
…g tile borders Do not try the following variable anchors, if the first variable anchor placement failed.
pozdnyakov
force-pushed
the
mikhail_tile_variable_labels
branch
from
c8d47ab to
2c1cae3
Compare
alexshalamov
reviewed
Jan 8, 2020
In order to remove the repeated code.
pozdnyakov
force-pushed
the
mikhail_tile_variable_labels
branch
from
9f22914 to
3efb7ce
Compare
alexshalamov
approved these changes
Jan 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things in Tile mode:
These changes allow to avoid cutting-off labels on tile borders if the variable text placement is enabled.
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/120