This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Introduce Scheduler::GetSequenced() API #15985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpsantos
approved these changes
Nov 28, 2019
tmpsantos
reviewed
Nov 28, 2019
| static std::mutex mtx; | ||
| static std::size_t lastUsedIndex = 0u; | ||
|
|
||
| if (++lastUsedIndex == kSchedulersCount) lastUsedIndex = 0u; |
There was a problem hiding this comment.
This is not thread safe, should be after the lock.
There was a problem hiding this comment.
thanks for the catch!
tmpsantos
reviewed
Nov 28, 2019
| @@ -41,4 +41,30 @@ std::shared_ptr<Scheduler> Scheduler::GetBackground() { | |||
| return scheduler; | |||
| } | |||
|
|
|||
| // static | |||
| std::shared_ptr<Scheduler> Scheduler::GetSequenced() { | |||
| const std::size_t kSchedulersCount = 10; | |||
There was a problem hiding this comment.
it's just an upper bound for the possible amount of threads, can be any other number.
The newly introduced `Scheduler::GetSequenced()` returns sequenced schedulers from the cache limited to 10 instances, preventing from spawning too many threads.
pozdnyakov
force-pushed
the
mikhail_scheduler_get_sequenced
branch
from
1404709 to
bbda46d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly introduced
Scheduler::GetSequenced()returns sequenced schedulers from the cache limited to 10 instances, preventing from spawning too many threads.Required for #15953 (comment)