This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Introduce overlays to MGLMapSnapshotter #15530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs changelog & tests, but wanted to push up the work I had so far. |
captainbarbosa
force-pushed
the
nb-snapshot-overlay
branch
from
338dc53 to
6f85b9f
Compare
captainbarbosa
changed the title
captainbarbosa
force-pushed
the
nb-snapshot-overlay
branch
from
0d4e9b8 to
7a4d815
Compare
|
TODO:
@julianrex would love your feedback now, especially on the test 👀 thanks! |
captainbarbosa
force-pushed
the
nb-snapshot-overlay
branch
from
c53ce87 to
9024144
Compare
|
@julianrex Finished tests, added docs, and edited changelog - ready for your review! |
captainbarbosa
force-pushed
the
nb-snapshot-overlay
branch
from
9024144 to
4a3808f
Compare
julianrex
reviewed
Sep 13, 2019
platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m
Show resolved
Hide resolved
platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m
Outdated
Show resolved
Hide resolved
captainbarbosa
force-pushed
the
nb-snapshot-overlay
branch
4 times, most recently
from
dadb7bc to
6aba177
Compare
julianrex
reviewed
Sep 13, 2019
julianrex
approved these changes
Sep 13, 2019
1ec5
reviewed
Sep 13, 2019
captainbarbosa
force-pushed
the
nb-snapshot-overlay
branch
from
6aba177 to
8019995
Compare
|
In 32f464c I took the liberty of adding corresponding macOS support. |
1ec5
reviewed
Sep 13, 2019
captainbarbosa
force-pushed
the
nb-snapshot-overlay
branch
from
32f464c to
99d0a83
Compare
|
Follow up work -> #15695 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to include an image overlay on anMGLMapSnapShotby specifying an array of overlays withinMGLMapSnapShotOptions.Adds a new method to
MGLMapSnapShotterwhich provides theCGContextof the snapshot to the developer for further customization.