[core] fix collisionBox alignment when Icon/text translation is enabled

[zmiao]

Fix partially of #13526
Render test: mapbox/mapbox-gl-js#8659

[pozdnyakov]

Looks nice! My only concern is memory usage, @zmiao do you have some estimations of the memory consumption impact caused by the change?

[astojilj]

Looks nice! My only concern is memory usage, @zmiao do you have some estimations of the memory consumption impact caused by the change?

@pozdnyakov , @zmiao
I didn't review the patch yet... what could cause increased memory consumption?

[pozdnyakov]

what could cause increased memory consumption?

The icon collision data might require more memory

[alexshalamov]

lgtm, for rendering fix, +1 for comments from @pozdnyakov

One thing is unclear, should we move collision feature when icon / text is translated? If so, #13526 is only partially fixed.

[zmiao]

@pozdnyakov @astojilj the number of the vertexes remains the same, only change is the container is split as two which hold text and icon separately. So no extra memory is added.

[pozdnyakov]

@pozdnyakov @astojilj the number of the vertexes remains the same, only change is the container is split as two which hold text and icon separately. So no extra memory is added.

I guess it's just + sizeof(CollisionBoxBuffer) per bucket, think its fine. Thanks!