Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Favor previous anchor only when still in the text-variable-anchor options #15129

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

pozdnyakov
Copy link
Contributor

@pozdnyakov pozdnyakov self-assigned this Jul 16, 2019
@pozdnyakov pozdnyakov added Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS labels Jul 16, 2019
@asheemmamoowala
Copy link
Contributor

@pozdnyakov Can you update the gl-js submodule pin with this change to validate the new render test, or are there other ports inprogress that prevent the submodule from being updated?

Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  • pinning gl-js that has render tests for new functionality

@pozdnyakov pozdnyakov force-pushed the mikhail_port_js8473 branch from 6ba0f80 to f59e351 Compare July 17, 2019 08:47
@pozdnyakov pozdnyakov force-pushed the mikhail_port_js8473 branch from f59e351 to 05285a7 Compare July 17, 2019 10:50
@pozdnyakov pozdnyakov requested a review from 1ec5 as a code owner July 17, 2019 10:50
@pozdnyakov pozdnyakov requested a review from a team July 17, 2019 10:50
@pozdnyakov pozdnyakov merged commit f63a906 into master Jul 17, 2019
@pozdnyakov pozdnyakov deleted the mikhail_port_js8473 branch July 17, 2019 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants