Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Added annotation selection tests with rotation & scaling of the map #15123

Merged
merged 6 commits into from
Aug 20, 2019

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented Jul 15, 2019

WIP - needs some cleanup, but ok for an initial review.

Adds integration tests to check annotation selection after rotating or zooming the map (not via a gesture).

@julianrex julianrex added iOS Mapbox Maps SDK for iOS tests labels Jul 15, 2019
@julianrex julianrex requested a review from friedbunny July 15, 2019 17:22
@julianrex julianrex added this to the release-q milestone Jul 16, 2019
@julianrex
Copy link
Contributor Author

@astojilj in the light of #15130 - how would you recommended I update this PR?

@astojilj
Copy link
Contributor

astojilj commented Aug 6, 2019

@astojilj in the light of #15130 - how would you recommended I update this PR?

Sorry for late response. Covered in #15123 (comment)

@julianrex julianrex force-pushed the jrex/rotation-tests branch from 725687a to d821c6f Compare August 20, 2019 14:10
@julianrex julianrex marked this pull request as ready for review August 20, 2019 14:11
@julianrex julianrex requested a review from a team August 20, 2019 14:11
Copy link
Contributor

@astojilj astojilj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianrex julianrex merged commit c0cd8d0 into master Aug 20, 2019
@julianrex julianrex deleted the jrex/rotation-tests branch August 20, 2019 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants