[ios] Add MGLMapViewZoomTests and clean-up other gesture tests #15117

friedbunny · 2019-07-13T01:01:55Z

Adds MGLMapViewZoomTests, which exercise MGLMapView.zoomLevel and its friends.
Adds a regression test for [ios] Fix incorrect center coordinate after pinch gesture #15097 — see -[MGLMapViewZoomTests testPinchGestureOffCenter].
- Note that this test will fail until [ios] Fix incorrect center coordinate after pinch gesture #15097 is merged and this PR rebased.
Reorganizes some of the newly-added compass tests, moving some things out of the direction tests.
Adds center coordinate checks to some direction/rotation gesture tests.

platform/ios/test/MGLMapViewZoomTests.m

friedbunny · 2019-07-13T01:14:57Z

platform/ios/test/MGLMapViewZoomTests.m

+    return pow(2, zoom);
+}
+
+__unused NS_INLINE double MGLZoomLevelFromScale(CGFloat scale) {


Not currently used, but could be useful in future.

platform/ios/test/MGLMapViewZoomTests.m

astojilj

LGTM

friedbunny added iOS Mapbox Maps SDK for iOS tests labels Jul 13, 2019

friedbunny added this to the release-picklejuice milestone Jul 13, 2019

friedbunny requested review from julianrex and a team July 13, 2019 01:01

friedbunny self-assigned this Jul 13, 2019

friedbunny force-pushed the friedbunny-adds-pinch-gesture-tests-and-such branch from 3448860 to 15595cb Compare July 13, 2019 01:04

friedbunny commented Jul 13, 2019

View reviewed changes

platform/ios/test/MGLMapViewZoomTests.m Outdated Show resolved Hide resolved

friedbunny commented Jul 13, 2019

View reviewed changes

platform/ios/test/MGLMapViewZoomTests.m Outdated Show resolved Hide resolved

friedbunny added 2 commits July 15, 2019 13:16

[ios] Clean-up direction and compass tests

0f30f23

[ios] Check center coordinate in MGLMapViewDirectionTests

28b1e72

friedbunny force-pushed the friedbunny-adds-pinch-gesture-tests-and-such branch from 15595cb to 0f0af1f Compare July 15, 2019 20:17

[ios] Add MGLMapViewZoomTests

6d4ef21

friedbunny force-pushed the friedbunny-adds-pinch-gesture-tests-and-such branch from 0f0af1f to 6d4ef21 Compare July 15, 2019 20:31

astojilj approved these changes Jul 17, 2019

View reviewed changes

friedbunny merged commit 5b820a9 into master Jul 17, 2019

friedbunny deleted the friedbunny-adds-pinch-gesture-tests-and-such branch July 17, 2019 19:38

Provide feedback