Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Tile updates the contained layer properties based on constants mask #15016

Merged
merged 5 commits into from
Jul 2, 2019

Conversation

pozdnyakov
Copy link
Contributor

Use layer data-driven properties constants mask to verify that the given layer properties are compatible with the existing buckets.
Thus, the updated paint properties can applied for rendering even before the tile re-layout completes.

Fixes: #14939

@pozdnyakov pozdnyakov requested a review from tmpsantos June 27, 2019 15:30
@pozdnyakov pozdnyakov added the Core The cross-platform C++ core, aka mbgl label Jun 27, 2019
@asheemmamoowala
Copy link
Contributor

@pozdnyakov Does this change and #14385 need to be ported to GL-JS as well?

@pozdnyakov
Copy link
Contributor Author

@pozdnyakov Does this change and #14385 need to be ported to GL-JS as well?

AFAIK gl-js is also preparing buckets in the tile worker thread, so buckets can get out of sync with the evaluated properties in meantime. These changes could be applied to fix this issue.

@friedbunny friedbunny added the needs changelog Indicates PR needs a changelog entry prior to merging. label Jun 28, 2019
@friedbunny friedbunny added this to the release-p milestone Jun 28, 2019
Constants mask for data-driven paint properties is a reliable
criteria of whether the given updated properties can still be used
with the existing bucket (and the gl program instance).
…remains

Thus, we do not have to wait for tile update completion in case
the updated properties have the same constants mask, i.e. fit
the existing bucket.
@pozdnyakov pozdnyakov force-pushed the mikhail_fix_layer_paint_properties_update branch from 0dae679 to bb5d638 Compare July 2, 2019 08:56
@pozdnyakov pozdnyakov requested a review from a team July 2, 2019 08:56
@pozdnyakov pozdnyakov force-pushed the mikhail_fix_layer_paint_properties_update branch 2 times, most recently from 46840ec to bb5d638 Compare July 2, 2019 12:36
@pozdnyakov pozdnyakov merged commit 664c50f into master Jul 2, 2019
@pozdnyakov pozdnyakov deleted the mikhail_fix_layer_paint_properties_update branch July 2, 2019 13:05
@friedbunny friedbunny removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl needs review rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style change transition regression
4 participants