This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Deprecate methods in favor of new completion handler versions #14959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
iOS
2 tasks
friedbunny
added
the
needs changelog
1ec5
reviewed
Jun 19, 2019
friedbunny
force-pushed
the
1ec5-animation-completion-5839
branch
2 times, most recently
from
082aa34 to
87fa146
Compare
friedbunny
force-pushed
the
friedbunny-deprecates-uncompletionful-methods-5839
branch
2 times, most recently
from
9d0802a to
6ed7420
Compare
friedbunny
changed the base branch from
1ec5-animation-completion-5839
to
master
friedbunny
force-pushed
the
friedbunny-deprecates-uncompletionful-methods-5839
branch
from
6ed7420 to
45b990d
Compare
friedbunny
removed
the
needs changelog
friedbunny
force-pushed
the
friedbunny-deprecates-uncompletionful-methods-5839
branch
from
45b990d to
8a9567e
Compare
|
Rebased to bring in the new render tests on CI. |
friedbunny
deleted the
friedbunny-deprecates-uncompletionful-methods-5839
branch
This was referenced Jul 26, 2019
Exclude Twitter reachability test from CocoaPods installation test
mapbox/mapbox-navigation-ios#2188
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates various
MGLMapViewmethods and replaces them with completion hander versions being added in #14381.This follows our best practices for deprecation, as outlined in #14560 (comment).
This will need changelogging and currently targets the #14381 branch — we should figure out the changelog when we merge that and retarget this PR.
/cc @1ec5 @julianrex