[ios] Add removeStyleImage to MGLMapView #14769
Conversation
|
We should wait for #14763 to land, as it moves a few things around. |
| @param mapView The map view that is evicting the image. | ||
| @param imageName The image name that is going to be removed. | ||
| */ | ||
| - (BOOL)mapView:(MGLMapView *)mapView removeStyleImage:(NSString *)imageName; |
There was a problem hiding this comment.
| - (BOOL)mapView:(MGLMapView *)mapView removeStyleImage:(NSString *)imageName; | |
| - (BOOL)mapView:(MGLMapView *)mapView shouldRemoveStyleImage:(NSString *)imageName; |
fabian-guerra
force-pushed
the
fabian-eviction-14731
branch
from
042f9b3 to
12cb77e
Compare
fabian-guerra
added
macOS
| goes over the cache size or when the image's requesting tile is destroyed. | ||
|
|
||
| @param mapView The map view that is evicting the image. | ||
| @param imageName The image name that is going to be removed. |
There was a problem hiding this comment.
Nit: Document the return value as well. (×2)
| Asks the delegate whether the map view should evict cached images. | ||
|
|
||
| This method is called in two scenarios: when the cumulative size of unused images | ||
| goes over the cache size or when the image's requesting tile is destroyed. |
There was a problem hiding this comment.
This method is called in two scenarios: when the cumulative size of unused images exceeds the cache size or when the last tile that includes the image is removed from memory.
(×2)
| @@ -333,6 +333,17 @@ NS_ASSUME_NONNULL_BEGIN | |||
| */ | |||
| - (nullable NSViewController *)mapView:(MGLMapView *)mapView calloutViewControllerForAnnotation:(id <MGLAnnotation>)annotation; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
This method appears under the “Managing Callout Popovers” heading in the header and in documentation:
Create a new heading for “Managing the Style” or move this method up to the “Loading the Map” section.
| @@ -277,6 +277,17 @@ NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| - (nullable UIImage *)mapView:(MGLMapView *)mapView didFailToLoadImage:(NSString *)imageName; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
This method appears under the “Managing Callout Views” heading in the header and in documentation:
Create a new heading for “Managing the Style” or move this method up to the “Loading the Map” section.
There was a problem hiding this comment.
On iOS is under the right header.
fabian-guerra
force-pushed
the
fabian-eviction-14731
branch
from
12cb77e to
0eda0b9
Compare
fabian-guerra
removed
the
needs changelog
fabian-guerra
force-pushed
the
fabian-eviction-14731
branch
from
0eda0b9 to
c24d67b
Compare
Fixes #14731