Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use URI instead of URL to enable asset loading #14750

Merged
merged 2 commits into from
May 27, 2019
Merged

Use URI instead of URL to enable asset loading #14750

merged 2 commits into from
May 27, 2019

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented May 23, 2019

Closes #14743

@tobrun tobrun added the Android Mapbox Maps SDK for Android label May 23, 2019
@tobrun tobrun added this to the release-oolong milestone May 23, 2019
@tobrun tobrun requested a review from LukasPaczos May 23, 2019 16:00
@tobrun tobrun self-assigned this May 23, 2019
@LukasPaczos
Copy link
Contributor

Good to ✅ as soon as the javadoc examples are added.

@tobrun tobrun force-pushed the tvn-uri-constructor branch 2 times, most recently from 83910ad to 20cee59 Compare May 27, 2019 14:15
LukasPaczos
LukasPaczos approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

You need to rebase to make the clang-tidy job pass.

@tobrun tobrun force-pushed the tvn-uri-constructor branch from 20cee59 to 39f9376 Compare May 27, 2019 16:20
@tobrun tobrun merged commit 1e97480 into master May 27, 2019
@tobrun tobrun deleted the tvn-uri-constructor branch May 27, 2019 17:21
@LukasPaczos LukasPaczos mentioned this pull request May 31, 2019
Closed
@tobrun tobrun mentioned this pull request Jun 4, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
release-oolong
Development

Successfully merging this pull request may close these issues.

GeoJSONSource constructor for asset/file URI
2 participants
@tobrun @LukasPaczos