Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Exclude CJK resources from offline download by default. #14176

Closed
julianrex opened this issue Mar 20, 2019 · 4 comments · Fixed by #14952
Closed

[ios] Exclude CJK resources from offline download by default. #14176

julianrex opened this issue Mar 20, 2019 · 4 comments · Fixed by #14952
Assignees
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS

Comments

@julianrex
Copy link
Contributor

See mapbox/mapbox-plugins-android#812 for Android equivalent.

Currently, CJK is included in offline regions (by default). See https://github.com/mapbox/mapbox-gl-native/pull/13607/files#diff-867d7f7add578b86f5456961d2bf8381R30

(The sample iosapp overrides this default based on the MGLIdeographicFontFamilyName value from the application's plist: https://github.com/mapbox/mapbox-gl-native/pull/13607/files#diff-bb284266f7a6a26739305814068fb1bfR107)

/cc @tobrun for coordination.
/cc @tmpsantos

Configuration

Mapbox SDK versions: 4.10

@julianrex julianrex added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Mar 20, 2019
@friedbunny friedbunny added the SEMVER-MAJOR Requires a major release according to Semantic Versioning rules label Mar 20, 2019
@friedbunny
Copy link
Contributor

friedbunny commented Mar 20, 2019

Tagging this as a semver-major change — offline packs have always included every glyph, so changing this behavior will break users outside the western world.

@tobrun
Copy link
Member

tobrun commented Mar 22, 2019

Note that the linked android issue in OP is for the offline plugin so no changes were made to the Android SDK just yet though would like to do the same.

@zugaldia
Copy link
Member

Capturing chat with the team, because we can make this change without changes to the public API, without breaking the rendering (local glyphs rendering is supported), it brings consistency with the changes already made to Snapshotter #13427, and because it reduces the size of the offline download (making the experience better), we're good to move forward with this change and removing the SEMVER major label 👍.

@zugaldia zugaldia removed the SEMVER-MAJOR Requires a major release according to Semantic Versioning rules label Mar 26, 2019
@zugaldia
Copy link
Member

Blocked by #14271.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants