Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Stable release v.4.7.0 cherry-picks #13600

Merged
merged 7 commits into from
Dec 18, 2018
Merged

Stable release v.4.7.0 cherry-picks #13600

merged 7 commits into from
Dec 18, 2018

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented Dec 18, 2018 •
edited
Loading

Picks:

EDIT:

alexshalamov and others added 2 commits December 18, 2018 09:03
@alexshalamov
[ios, darwin] Make MGLFeature.attributes non-nullable and add integra…
9518472 
…tion test

Enforce non-nullable semantics for MGLFeature.attributes, to avoid construction of invalid mbgl::Feature properties
from nil NSDictionary object and align with public SDK property definition.

Integration test "testShapeSourceWithLineDistanceMetrics" is added to verify that MGLFeature is correctly converted.

Fixes issue #13378
@julianrex
[core] Updated iOS/macOS change logs. (#13564)
b984a46
@julianrex julianrex added iOS Mapbox Maps SDK for iOS ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Dec 18, 2018
@julianrex julianrex added this to the release-iowaska milestone Dec 18, 2018
@julianrex julianrex requested a review from 1ec5 as a code owner December 18, 2018 14:24
@julianrex julianrex requested review from a team and captainbarbosa December 18, 2018 14:24
@julianrex julianrex self-assigned this Dec 18, 2018
@julianrex julianrex force-pushed the jrex/release-v.4.7.0-stable-cherrypicks branch from 811aac0 to 9e519df Compare December 18, 2018 16:32
@julianrex julianrex removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Dec 18, 2018
@julianrex julianrex merged commit 79cadec into release-iowaska Dec 18, 2018
@julianrex julianrex deleted the jrex/release-v.4.7.0-stable-cherrypicks branch December 18, 2018 22:43
@captainbarbosa captainbarbosa mentioned this pull request Dec 21, 2018
Merged
captainbarbosa added a commit that referenced this pull request Dec 21, 2018
@captainbarbosa
[ios, macos] Revert mapbox-streets-v8
d59bac3 
Reverts e36e4cf (Parent PR is #13600)

Changelog edits
captainbarbosa added a commit that referenced this pull request Dec 21, 2018
@captainbarbosa
[ios, macos] Revert mapbox-streets-v8
3726f7e 
Reverts e36e4cf (Parent PR is #13600)

Changelog edits
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@captainbarbosa captainbarbosa captainbarbosa approved these changes

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees

@julianrex julianrex

Labels
iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
release-iowaska
Development

Successfully merging this pull request may close these issues.
3 participants
@julianrex @captainbarbosa @alexshalamov