Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Update Events Library submodule to include china endpoint #12233

Merged
merged 1 commit into from
Jun 27, 2018
Merged

[ios] Update Events Library submodule to include china endpoint #12233

merged 1 commit into from
Jun 27, 2018

Conversation

rclee
Copy link
Contributor

@rclee rclee commented Jun 27, 2018

Brings in changes from #11860 and #11845

julianrex
julianrex approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@julianrex julianrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rclee
Copy link
Contributor Author

rclee commented Jun 27, 2018

I'm not sure why these tests are failing. Any recommendations?

@friedbunny
Copy link
Contributor

These look like npm connectivity issues, so the best bet is to keep rerunning the failed jobs.

Submodule path 'mapbox-gl-js': checked out 'f546de26b9b531a84fe621a5f51f4c0f791e57fb'
-- Running 'npm install' for mapbox-gl-native...
Makefile:644: recipe for target 'apackage' failed
make: *** [apackage] Terminated
Makefile:615: recipe for target 'android-lib-arm-v7' failed
make[1]: *** [android-lib-arm-v7] Hangup
Too long with no output (exceeded 10m0s)

Submodule path 'mapbox-gl-js': checked out 'f546de26b9b531a84fe621a5f51f4c0f791e57fb'
-- Running 'npm install' for mapbox-gl-native...
- [email protected] node_modules/block-stream
- [email protected] node_modules/fstream
- [email protected] node_modules/fstream-ignore
- [email protected] node_modules/uid-number
- [email protected] node_modules/tar-pack
@mapbox/[email protected] /src
├── @mapbox/[email protected] 
└─┬ [email protected] 
  ├─┬ [email protected] 
  │ └── [email protected] 
  ├─┬ [email protected] 
  │ ├── [email protected] 
  │ └── [email protected] 
  └─┬ [email protected] 
    ├── [email protected] 
    ├── [email protected] 
    ├── [email protected] 
    ├── [email protected] 
    └── [email protected] 

-- Running 'npm install' for mapbox-gl-js...
Makefile:305: recipe for target 'build/linux-x86_64/Debug/build.ninja' failed
make: *** [build/linux-x86_64/Debug/build.ninja] Terminated
Too long with no output (exceeded 10m0s)

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS telemetry Integration with Mapbox Telemetry libraries labels Jun 27, 2018
@friedbunny friedbunny added this to the ios-v4.2.0 milestone Jun 27, 2018
@rclee rclee merged commit 16c4208 into master Jun 27, 2018
@rclee rclee deleted the rclee-china-certs branch June 27, 2018 18:44
fabian-guerra pushed a commit that referenced this pull request Jun 27, 2018
@rclee @fabian-guerra
[ios] Update Events Library submodule to include china endpoint (#12233)
d7f366c 
Brings in changes from #11860 and #11845
@fabian-guerra fabian-guerra mentioned this pull request Jun 27, 2018
Merged
fabian-guerra pushed a commit that referenced this pull request Jun 27, 2018
@rclee @fabian-guerra
[ios] Update Events Library submodule to include china endpoint (#12233)
8ae32b7 
Brings in changes from #11860 and #11845
fabian-guerra pushed a commit that referenced this pull request Jun 28, 2018
@rclee @fabian-guerra
[ios] Update Events Library submodule to include china endpoint (#12233)
3a20a44 
Brings in changes from #11860 and #11845
@fabian-guerra fabian-guerra mentioned this pull request Jun 28, 2018
Merged
fabian-guerra pushed a commit that referenced this pull request Jun 28, 2018
@rclee @fabian-guerra
[ios] Update Events Library submodule to include china endpoint (#12233)
dfaa42c 
Brings in changes from #11860 and #11845
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@julianrex julianrex julianrex approved these changes

@1ec5 1ec5 Awaiting requested review from 1ec5

@lloydsheng lloydsheng Awaiting requested review from lloydsheng

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees

@rclee rclee

Labels
iOS Mapbox Maps SDK for iOS telemetry Integration with Mapbox Telemetry libraries
Projects
None yet
Milestone
ios-v4.2.0-drink
Development

Successfully merging this pull request may close these issues.
3 participants
@rclee @friedbunny @julianrex