This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Don't resolve tokens after evaluating a text-field or icon-image expression #11509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
approved these changes
Mar 22, 2018
| @@ -113,12 +113,11 @@ class CompositeFunction { | |||
|
|
|||
| const expression::Expression& getExpression() const { return *expression; } | |||
|
|
|||
| std::string property; | |||
| Stops stops; | |||
| optional<T> defaultValue; | |||
This was referenced Apr 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10399.
I opted for a fix equivalent to the current approach in gl-js, rather than the approach outlined in #10399 (comment). We should refactor to the latter on
master, but after getting started on it I think it's more involved than we want for boba.