This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
remove Level class #10964
Merged
remove Level class #10964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asheemmamoowala
approved these changes
Jan 19, 2018
| for (int32_t y = 0; y < level.dim; y++) { | ||
| for (int32_t x = 0; x < level.dim; x++) { | ||
| const int32_t i = y * level.dim + x; | ||
| std::memset(image.data.get(), 0, image.bytes()); |
There was a problem hiding this comment.
Not needed if all bits are being set in the for loop below.
There was a problem hiding this comment.
the loop doesn't set all bits bc there is an empty 254px border around the image (need 1px border, but also need texture to be power of 2)
src/mbgl/geometry/dem_data.cpp
Outdated
| set(-1, -1, get(0, 0)); | ||
| set(dim, -1, get(dim - 1, 0)); | ||
| set( -1, dim, get(0, dim - 1)); | ||
| set(dim, dim, get(dim - 1, dim - 1)); | ||
| loaded = true; |
There was a problem hiding this comment.
No longer need loaded flag ?
test/geometry/dem_data.test.cpp
Outdated
|
|
||
| } | ||
|
|
||
| dem0.backfillBorder(dem1, 0, -1); | ||
| // backfills TopCenter neighbor | ||
| for (int x = 0; x < 4; x++) { | ||
| EXPECT_TRUE(dem0.level.get(x, -1) == dem1.level.get(x, 3)); | ||
| EXPECT_TRUE(dem0.get(x, -1) == dem1.get(x, 3)); | ||
| } | ||
|
|
||
| dem0.backfillBorder(dem1, 1, 0); | ||
| // backfills Right neighb// backfulls TopRight neighboror |
mollymerp
force-pushed
the
remove-level
branch
from
126a178 to
ddaae82
Compare
mollymerp
force-pushed
the
raster-hillshade
branch
from
0b491fa to
81d425c
Compare
mollymerp
force-pushed
the
remove-level
branch
from
ddaae82 to
e633333
Compare
mollymerp
pushed a commit
that referenced
this pull request
Jan 23, 2018
add DEMPyramid class add raster-dem source and hillshade layer types update with layer-specific lighting properties fix build errors use 3dpass for hillshade prepare step fix DEM population, change border to int32 update shaders and fix rendering update gl-js sha and un-ignore hillshade render tests start backfill border logic remove unused dem pyramid code implement backfill border use bitmask to keep track of backfilled neighbors fix tests TileCache::get -> TileCache::pop, add new getter fix node build remove unnecessary std::move override/final onTileChanged update hillshade shaders android style code update hillshade shaders appease clang-tidy address review comments use enum for neighboring tiles enforce+update DEMTileNeighbors type add RasterDEMTile test clean up DEMPyramid define constructor for DEMPyramid test DEMPyramid DEMPyramid->DEMData return reference to DEMData instead of pointer refactor backfillBorder owner fix texture filter and wrap settings remove hardcoded tilesizes and allow for @2x tile requests address review comments make RasterDEMSource inherit from RasterSource (#10952) comment DEMData::backfillBorder guard against redoing backfill work for the borderTile add RasterDEMSource tests reenable all builds ios codegen remove Level class (#10964) cleanup and add hillshade to android style layer exceptions dim as uint32 guard against nullptr borderBucket
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.