Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLGeoJSONSource.data should be NSData, not NSString #5965

Closed
1ec5 opened this issue Aug 11, 2016 · 0 comments · Fixed by #6029
Closed

MGLGeoJSONSource.data should be NSData, not NSString #5965

1ec5 opened this issue Aug 11, 2016 · 0 comments · Fixed by #6029
Assignees
@1ec5
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 11, 2016

MGLGeoJSONSource’s data property should be of type NSData, not NSString. NSData is the type that NSJSONSerialization traffics in, probably because it’s more efficient to scan a data blob than a UTF-16 string.

/cc @frederoni
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Aug 11, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 11, 2016
@1ec5 1ec5 mentioned this issue Aug 11, 2016
Closed
@1ec5 1ec5 self-assigned this Aug 12, 2016
@1ec5 1ec5 mentioned this issue Aug 16, 2016
Merged
1ec5 added a commit that referenced this issue Aug 18, 2016
@1ec5
[ios, macos] More MGLGeoJSONSource options
7b1f901 
MGLGeoJSONSource can now be initialized with GeoJSON data. Replaced the data property with a geoJSONData property and added features and URL properties alongside it. Each property may be set or unset based on how the object was initialized.

Fixes #5965, fixes #5966.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Milestone
ios-v3.4.0
Development

Successfully merging a pull request may close this issue.

More MGLGeoJSONSource options mapbox/mapbox-gl-native
2 participants
@boundsj @1ec5