Visible Feature querying

[ivovandongen]

This ticket is the android implementation of #352 or query rendered features.

In order to implement this we need to lay some groundwork, mostly because we already have a full geometry implementation in https://github.com/mapbox/mapbox-java/ that we will want to re-use. At first we resisted adding MAS as a dependency since it currently has a dependency on rxjava, which is quite big. However, work is underway as we speak to remove that dependency in: mapbox/mapbox-java#131.

This implementation will add methods to query the layers currently rendered (or a subset of layers) and retrieve the GeoJson Features present either for a point or area.

[ivovandongen]

Little update: Initial querying is done:

• point query -> returns features, incl:
  • id
  • properties as JsonObjects
  • geometry as MAS GeoJson types

Todo:

• box query - much re-use
• update mas to new snapshot
• Optimization: use primitive double arrays instead of typed objects from jni: GeoJson: Add factory methods to create Geometries from primitive arrays mapbox-java#171

Beside the above. Do we need any other conversions from/to geojson in the sdk?

cc @zugaldia

[zugaldia]

@ivovandongen Love it.

I can take care of the latest two items in that checklist.

[ivovandongen]

@zugaldia @cammace prepared the second item on #5927

If you don't mind picking up mapbox/mapbox-java#171 that would be great!

[zugaldia]

@ivovandongen mapbox/mapbox-java#171 ✅

[ivovandongen]

Squashed: #6012

Needs some testing on older devices to make sure were not using top many local references in conversion.

[ivovandongen]

[ivovandongen]

Merged

[mkv123]

@ivovandongen: Is it intentional that using this feature requires pulling in mapbox services as a new dependancy? Or is there a plan/ticket to move the geojson classes this feature requires into the normal mapbox sdk?

[ivovandongen]

@mkv123 Yes, this is intentional. If you're worried about apk size, proguard has you covered.