Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

-[MGLMapView viewForAnnotation:] #5406

Closed
1ec5 opened this issue Jun 19, 2016 · 2 comments
Closed

-[MGLMapView viewForAnnotation:] #5406

1ec5 opened this issue Jun 19, 2016 · 2 comments
Labels
annotations Annotations on iOS and macOS or markers on Android iOS Mapbox Maps SDK for iOS

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jun 19, 2016

For parity with MapKit, we should add a method to MGLMapView that looks like:

- (nullable MGLAnnotationView *)viewForAnnotation:(id<MGLAnnotation>)annotation SWIFT_NAME(view(for:));

which would bridge to Swift as:

func view(for annotation: MGLAnnotation) -> MGLAnnotationView?

/cc @frederoni @boundsj
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS annotations Annotations on iOS and macOS or markers on Android labels Jun 19, 2016
@obrhoff
Copy link

obrhoff commented Jun 19, 2016

The same should apply to

- (void)mapView:(MGLMapView *)mapView didAddAnnotationViews:(NSArray<MGLAnnotationView *> *)views

frederoni added a commit that referenced this issue Jun 20, 2016
@frederoni
[ios] fixes #5406 view for annotation
976e238
@boundsj boundsj mentioned this issue Jun 21, 2016
Merged
frederoni added a commit that referenced this issue Jun 21, 2016
@frederoni
[ios] fixes #5406 view for annotation (#5413)
3995d6f
@boundsj
Copy link
Contributor

boundsj commented Jun 24, 2016

@DocterD The same should apply to

  • (void)mapView:(MGLMapView *)mapView didAddAnnotationViews:(NSArray<MGLAnnotationView *> *)views

Noting that this was picked up in #5465

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
annotations Annotations on iOS and macOS or markers on Android iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@boundsj @obrhoff @frederoni @1ec5