Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Refactor tracking modes + make configurable #3899

Closed
tobrun opened this issue Feb 11, 2016 · 4 comments
Closed

Refactor tracking modes + make configurable #3899

tobrun opened this issue Feb 11, 2016 · 4 comments
Labels
Android Mapbox Maps SDK for Android refactor
Milestone
android-v4.0.0

Comments

@tobrun
Copy link
Member

tobrun commented Feb 11, 2016

We first refactored MapView into MapboxMap and afterwards start moving contents from MapboxMap into smaller testable classes eg. UiSettings and Projection. I'm suggesting to do the same for anything related to tracking modes. This class will also be responsible for configuration.

eg.
I have been hearing about not stopping tracking when a gesture occurs.
@tobrun tobrun added refactor Android Mapbox Maps SDK for Android labels Feb 11, 2016
@tobrun tobrun added this to the android-v4.0.0 milestone Feb 11, 2016
@tobrun
Copy link
Member Author

tobrun commented Feb 11, 2016

Going to pick this up for map padding in #3761 because it is impossible to test gestures with LocationTracking enabled.

@tobrun
Copy link
Member Author

tobrun commented Feb 11, 2016

Here is an example how the API will look for end users:
screen shot 2016-02-11 at 10 12 07

@tobrun
Copy link
Member Author

tobrun commented Feb 11, 2016

The benefit that this gives is that setMyLocationEnabled and setMyLocationTrackingMode are now found on separate classes. This will make the api more concrete and will lower developer friction when autocompleting (eg. less confusion because our specific API's are hidden versus google parity api's).

tobrun added a commit that referenced this issue Feb 11, 2016
@tobrun
[android] #3781 #3899 - add map padding, user location view, ViewSett…
ee960ec 
…ings, TrackingSettings
@tobrun tobrun mentioned this issue Feb 12, 2016
Closed
tobrun added a commit that referenced this issue Feb 15, 2016
@tobrun
[Android] #3761 - add map padding, introduce new feature activity
1b7ebca 
[android] #3781 #3899 - add map padding, user location view, ViewSettings, TrackingSettings

[android] #3761 - update map padding sample

[android] #3761 - add map padding
@tobrun
Copy link
Member Author

tobrun commented Feb 15, 2016

Landed with #3942

@tobrun tobrun closed this as completed Feb 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android refactor
Projects
None yet
Milestone
android-v4.0.0
Development

No branches or pull requests
1 participant
@tobrun