Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

fix iOS device rotation #37

Closed
incanus opened this issue Feb 4, 2014 · 3 comments
Closed

fix iOS device rotation #37

incanus opened this issue Feb 4, 2014 · 3 comments
Labels
Milestone

Comments

@incanus
Copy link
Contributor

incanus commented Feb 4, 2014

Rotating device changes aspect ratio on the fly and GL context needs to compensate. Disabling in app for now.

img_0595

incanus added a commit that referenced this issue Feb 4, 2014
@incanus incanus self-assigned this Feb 13, 2014
@incanus incanus removed their assignment Mar 19, 2014
@kkaefer
Copy link
Member

kkaefer commented Apr 10, 2014

  • We should update the dimensions mid-rotation, not at the beginning, to decrease the initial distortion
  • There is a black flicker when rotation begins

kkaefer added a commit that referenced this issue Apr 10, 2014
@incanus incanus added this to the WWDC milestone Apr 29, 2014
@kkaefer
Copy link
Member

kkaefer commented Apr 30, 2014

This used to be fixed by moving to GLKViewController. However, I reverted this change and when you now turn the device, the screen turns black until you touch it.

I suspect that iOS allocates/changes to a new framebuffer once you turn the device and displays it. We somehow need to intercept that and force an immediate render before the new buffer is displayed to avoid a black flicker.

@incanus
Copy link
Contributor Author

incanus commented May 28, 2014

This no longer happens. Related: cutting-room-floor/mapbox-gl-cocoa#20

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants