Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Symbols not being rendered in empty style #14751

Closed
tobrun opened this issue May 23, 2019 · 4 comments · Fixed by #15293
Closed

Symbols not being rendered in empty style #14751

tobrun opened this issue May 23, 2019 · 4 comments · Fixed by #15293
Labels
Android Mapbox Maps SDK for Android bug

Comments

@tobrun
Copy link
Member

tobrun commented May 23, 2019

release-java

image

master

image

Issue can be reproduced with the Simple Map Activity using the following commit: 48abc96

cc @tmpsantos @pozdnyakov @alexshalamov

@tobrun tobrun added bug Core The cross-platform C++ core, aka mbgl labels May 23, 2019
@pozdnyakov pozdnyakov self-assigned this May 24, 2019
@pozdnyakov
Copy link
Contributor

The issue was introduced with 103f86c
cc @LukasPaczos

@pozdnyakov pozdnyakov removed their assignment May 24, 2019
@pozdnyakov pozdnyakov added Android Mapbox Maps SDK for Android and removed Core The cross-platform C++ core, aka mbgl labels May 24, 2019
@LukasPaczos
Copy link
Contributor

LukasPaczos commented May 31, 2019

I took this for a spin:

  • calling Style::Impl::loadJSON with an empty style string fails
  • calling Style::Impl::loadURL with an empty style asset works

Both methods deliver an identical string to Style::Impl::parse. This can be reproduced by commenting/uncommenting this line in db3b980.

Is this an underlying core issue, or is there a reason for this behavior @pozdnyakov? We can change the implementation to use the asset (and the file source request) instead of parsing the style right away, but I'd like to understand why.

@tmpsantos
Copy link
Contributor

Accordingly to the style spec, this is the minimum valid style:

{
  "version": 8,
  "sources": {}, 
  "layers": []
}

@LukasPaczos
Copy link
Contributor

This is what an example from #14751 (comment) uses, which leads me to believe that Style::Impl::loadJSON is not kicking off the right gears internally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants