This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Request JIT accuracy #392
Merged
Request JIT accuracy #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
added
documentation
julianrex
reviewed
Aug 25, 2020
platform/ios/src/MGLMapView.mm
Outdated
Comment on lines
6106
to
6116
| if (@available(iOS 14, *)) { | ||
| if ((manager.authorizationStatus != kCLAuthorizationStatusRestricted || | ||
| manager.authorizationStatus != kCLAuthorizationStatusAuthorizedAlways || | ||
| manager.authorizationStatus != kCLAuthorizationStatusAuthorizedWhenInUse) && | ||
| manager.accuracyAuthorization == CLAccuracyAuthorizationReducedAccuracy && | ||
| [self accuracyDescriptionString] != nil ) { | ||
| [self.locationManager requestTemporaryFullAccuracyAuthorizationWithPurposeKey:@"MBXAuthorizationAccuracyDescription"]; | ||
| } else { | ||
| [self validateLocationServices]; | ||
| } |
There was a problem hiding this comment.
Do we need a #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 140000 here?
fabian-guerra
force-pushed
the
fabian-jit-autorequest
branch
from
c0810bf to
e7ae563
Compare
neelmistry94
approved these changes
Aug 25, 2020
|
LGTM, no concerns |
captainbarbosa
approved these changes
Aug 25, 2020
jmkiley
reviewed
Aug 25, 2020
| @@ -10,6 +10,21 @@ Mapbox-hosted vector tiles and styles require an API access token, which you can | |||
|
|
|||
| As an alternative, you can use `MGLAccountManager.accessToken` to set a token in code. See [our guide](https://www.mapbox.com/help/ios-private-access-token/) for some tips on keeping access tokens in open source code private. | |||
|
|
|||
| ## MGLAccuracyAuthorizationDescription | |||
|
|
|||
| Set the Mapbox accuracy authorization description string as an element of `NSLocationTemporaryUsageDescriptionDictionary` to be used by the map to request authorization when the `MGLLocationManager.accuracyAuthorization` is set to `CLAccuracyAuthorizationReducedAccuracy`. | |||
There was a problem hiding this comment.
Should we note that this is only available in iOS 14+?
fabian-guerra
removed
documentation
fabian-guerra
force-pushed
the
fabian-jit-autorequest
branch
from
e7ae563 to
89e70fc
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new Info.plist property to request accuracy authorization when the accuracy is
CLAccuracyAuthorizationReducedAccuracyand has authorized location updates.