Update attribution on layer visibility changes #9943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9824. Attribution is currently updated when the style changes (layers and sources added/removed, properties changed, etc.), but not updated when source visibility changes during zooming — either through going in or out of
minzoom
/maxzoom
range, or throughopacity
change from zero to non-zero values or vice versa (e.g. through a zoom-based expression).This PR introduces a new
sourcedata
event withsourceDataType: 'visibility'
, which the attribution control subsequently subscribes to for updating the attribution.Launch Checklist
mapbox-gl-js
changelog:<changelog>Fix a bug where attribution didn't update when layer visibility changed during zooming.</changelog>