Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the worker images once an image is added or removed. #9838

Closed

Conversation

francois2metz
Copy link
Contributor

This fix a bug when a fallback image was not used when it was added via addImage.

For instance, the following style with a missing image nonexistant and an added image shop would show nothing.

   "icon-image": [
      "coalesce",
      ['image', 'nonexistant'],
      ['image', 'shop']
    ]

I also updated the list of images on the worker when an image is removed to keep it synchronized.

@francois2metz francois2metz force-pushed the update-images-after-add branch from c65dfc0 to 994b406 Compare July 4, 2020 16:45
@francois2metz francois2metz changed the title Update the worker images once an image is add or removed. Update the worker images once an image is added or removed. Jul 5, 2020
@francois2metz francois2metz force-pushed the update-images-after-add branch from 994b406 to 1f62a19 Compare July 5, 2020 09:25
@mourner mourner requested a review from ansis July 6, 2020 12:53
@ryanhamley
Copy link
Contributor

Hi @francois2metz can you open an issue that corresponds to the problem this PR is trying to fix, including a minimal example of the bug? I think this change makes some sense but I want to ensure that this doesn't cause unnecessary tile loads.

@francois2metz
Copy link
Contributor Author

@ryanhamley Good point, I did it: #9900

@karimnaaji
Copy link
Contributor

karimnaaji commented Aug 3, 2020

This looks great @francois2metz , I confirm the behavior. Thanks for adding a description of the issue. I continued this PR in #9911 with render test coverage, which is confirmed to fail on main branch. We can close this PR and continue the discussion there.

@karimnaaji karimnaaji closed this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants