Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-caspian] Ensure padding is not propagated from fitBounds to transform padding #9480

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

arindam1993
Copy link
Contributor

Fixes #9477 .
It fixes a bug wherein padding passed to fitBounds also gets propagated to easeTo which causes padding to be accounted for in both the bounds calculation and asymmetric viewport calculation.

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog:
    Fixes a bug in map.fitBounds wherein the padding passed to options would be applied twice. Fixes #9477

@arindam1993 arindam1993 requested a review from ryanhamley March 30, 2020 22:03
@arindam1993 arindam1993 changed the title Ensure padding is not propagated from fitBounds to transform padding [release-caspian] Ensure padding is not propagated from fitBounds to transform padding Mar 30, 2020
@arindam1993 arindam1993 linked an issue Mar 31, 2020 that may be closed by this pull request
@arindam1993 arindam1993 merged commit e59e48a into release-caspian Mar 31, 2020
@arindam1993 arindam1993 deleted the fix-fit-bounds branch March 31, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map.fitBounds(...) behaves differently in v 1.9.0
2 participants