Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload the entire font range when a glyph is missing in a font #9375

Merged
merged 9 commits into from
Mar 23, 2020
+49 −17
Merged

Don't reload the entire font range when a glyph is missing in a font #9375

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f4d22e7
Ignore missing glyph when font range is already loaded
oterral Mar 4, 2020
b078eca
Add test
oterral Mar 4, 2020
e21bbec
lint
oterral Mar 4, 2020
0fc9d66
Fix tests
oterral Mar 4, 2020
640824a
Remove line
oterral Mar 4, 2020
41f017c
Remove line
oterral Mar 4, 2020
f08da01
Lint
oterral Mar 5, 2020
9568dac
Add ranges flow definition
oterral Mar 5, 2020
6621b71
Use helpers function
oterral Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint
@oterral
oterral committed Mar 5, 2020

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tvdeyen Thomas von Deyen
GPG key ID: F2548C2CBA04A848
Expired
Verified
Learn about vigilant mode
commit f08da011903a878d40448892d37550bf213d1661
4 changes: 2 additions & 2 deletions test/unit/render/glyph_manager.test.js
View file
Original file line number Diff line number Diff line change
@@ -41,15 +41,15 @@ test('GlyphManager doesn\'t request twice 0-255 PBF if a glyph is missing', (t)
const manager = new GlyphManager(identityTransform);
manager.setURL('https://localhost/fonts/v1/{fontstack}/{range}.pbf');

manager.getGlyphs({'Arial Unicode MS': [0.5]}, (err, glyphs) => {
manager.getGlyphs({'Arial Unicode MS': [0.5]}, (err) => {
t.ifError(err);
t.equal(manager.entries['Arial Unicode MS'].ranges[0], true);
t.equal(stub.calledOnce, true);

// We remove all requests as in getGlyphs code.
delete manager.entries['Arial Unicode MS'].requests[0];

manager.getGlyphs({'Arial Unicode MS': [0.5]}, (err, glyphs) => {
manager.getGlyphs({'Arial Unicode MS': [0.5]}, (err) => {
t.ifError(err);
t.equal(manager.entries['Arial Unicode MS'].ranges[0], true);
t.equal(stub.calledOnce, true);