Few fixes and additional API's for performance metrics instrumentation #9179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
reviewed
Jan 27, 2020
| window.fetch(request).then(response => { | ||
| _inflightRequestCount = Math.max(_inflightRequestCount - 1, 0); |
There was a problem hiding this comment.
Is the max there to handle double-decrements in case both an error handler and .cancel() are called? Would doing something id-based be more reliable?
const reqId = nextId++;
activeRequests[reqId] = true;
delete activeRequests[reqId];
infLightRequests = Object.keys(activeRequests).length;
There was a problem hiding this comment.
yes, that is correct! I thought about that too, but I was trying to keep the instrumentation as low runtime overhead as possible
ryanhamley
reviewed
Jan 31, 2020
src/style/style.js
Outdated
Comment on lines
367
to
370
| * Apply queued style updates in a batch and recalculate zoom-dependent paint properties. | ||
| * | ||
| * @param parameters | ||
| */ |
There was a problem hiding this comment.
This seems like an automatic linting change but the comment is misaligned now.
added 14 commits
March 6, 2020 16:39
This reverts commit 48f5b5a.
ryanhamley
force-pushed
the
fix-intrumentation
branch
from
23a5ab4 to
fdb251f
Compare
|
1 task
|
Do we still need this @arindam1993 ? |
|
Looks like this is stale now — let's revisit later if it's still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #9035, with a few fixes and some additional API methods that help improve the reliability of collected metrics.
Primarily this adds 3 new methods:
map.style.disableFetchCancellation()/map.style.enableFetchCancellation(): This lets the test-runner disable request cancellation for acache-prewarmrun, which is run prior to the actual measurement runs. This ensures that all possible tiles that are required for the run are precached during the actual measurement run.map.style.getNumInflightRequests(): This is used by the test-runner to wait until all in-flight requests are finished for acache-prewarmrun, again ensuring maximum cache-warmth. 🔥Launch Checklist