[docs] Remove /map-tiles GL JS example #8274
Conversation
The redirect is put in place elsewhere right? |
|
@asheemmamoowala correct! The redirect will happen in https://github.com/mapbox/subdomain-docs/pull/29 I will merge here after the redirect PR is merge |
|
👋 @katydecorah I find the "Add a raster tile source" example very helpful, it demonstrates how to add a 3rd party raster tile layer to a map. So I think it's useful to keep. If there's a concern about using the classic style, perhaps we could point it to a different raster tile source? The satellite example is good, but since it just uses the default mapbox satellite style, it doesn't quite show the same thing. |
This reverts commit ea8bf28.
If the value of this example is to show how to add a raster tile source that does not have a TileJSON file, then maybe we can show how to add the mapbox satellite tile layer with in-lined |
@asheemmamoowala I think this could get confusing for the reader since we have a separate example for using the satellite style https://docs.mapbox.com/mapbox-gl-js/example/satellite-map/, which I believe is the preferred method. A reader looking for the way to add Mapbox satellite imagery to their application may not be sure which to use. |
docs/pages/example/map-tiles.html
Outdated
| "tileSize": 256 | ||
| "tiles": ["http://tile.stamen.com/watercolor/{z}/{x}/{y}.jpg"], | ||
| "tileSize": 256, | ||
| "attribution": '<a id="home-link" target="_top" href="../" class="">Map tiles</a> by <a target="_top" href="http://stamen.com">Stamen Design</a>, under <a target="_top" href="http://creativecommons.org/licenses/by/3.0">CC BY 3.0</a>. Data by <a target="_top" href="http://openstreetmap.org">OpenStreetMap</a>, under <a target="_top" href="http://creativecommons.org/licenses/by-sa/3.0" class="">CC BY SA</a>' |
There was a problem hiding this comment.
how about this?
Map tiles by <a target="_top" rel="noopener" href="http://stamen.com">Stamen Design</a>, under <a target="_top" rel="noopener" href="http://creativecommons.org/licenses/by/3.0">CC BY 3.0</a>. Data by <a target="_top" rel="noopener" href="http://openstreetmap.org">OpenStreetMap</a>, under <a target="_top" rel="noopener" href="http://creativecommons.org/licenses/by-sa/3.0">CC BY SA</a>
|
👋 @katydecorah can you take a look at the changes I made, rebase, and merge if all looks good? |
* publisher-production: [docs] updates to search component and layout (#8362) [docs] adds docs-wide search component (#8349) [DOCS] Update Popup maxWidth description (#8312) [docs] update docs-page-shell (#8254) v1.0.0 (#8277) Add sku token to Mapbox API tile requests (#14) (#8276) @mapbox/mapbox gl style [email protected] (#8264)
* [docs] adds docs-wide search component (#8349) * update dr-ui, mr-ui * add search component * adjust columns to prevent overlap * v1.1.0-beta.1 (#8353) * Update CHANGELOG.md for v1.1.0-beta.1 release * Bump package.json version to 1.1.0-beta.1 * [docs] updates to search component and layout (#8362) * do not index /api sidebar * exclude code snippets in examples from being indexed * Update docs-page-shell * update dr-ui, react, react-dom * adjust columns to fit search and navigation better * [docs] Replace example with a third-party raster source (#8274) * remove Add a raster tile source example * revert "remove Add a raster tile source example" This reverts commit ea8bf28. * add third-party tiles to map-tiles example * fix attribution * rm unused var * Add mapbox-gl-framerate to plugins list (#8356) * remove old plugins page and update reference to the maintained version (#8369) * Add link to iOS SDK documentation (#8359) * add ios sdk link per comment from stephen g * add new link from minh and reword * Include Hiragana and Katakana code blocks for local glyph generation (#8365) (#8378) * document the tile size drawn with showTileBoundaries (#8379) * use browser `Cache` interface to cache tiles (#8363) Recent pricing changes introduced a `sku=` query parameter that changes with every map load. This defeats the browser's ability to cache these tiles. We're working around that by implementing our own caching with the new `Cache` api. - skips caching tiles that expire soon - only caches mapbox tiles (no 3rd party tiles, styles, etc because the browser should cache these fine) - does not work in IE, Safari Browser tests can be found in debug/cache_api.html mapboxgl.clearStorage added to provide a way to clear the cache. * fix cache support check for enforcing size limit This was throwing errors in browsers that don't support the cache api but wasn't previously noticed because it was not breaking anything. * Fix background rotation hovering (#8367) * update changelog * [email protected] (#8297) * [email protected] * add one more file to v4.4.0 * fix Response construction in Edge, fix #8391 (#8392) (#8394) Edge does not support constructing responses with readable streams. * v1.1.0-beta.2 (#8395) * Add sdk support spec section for text-radial-offset (#8384) (#8401) This PR also assigns SDK versions for the `text-variable-anchor` property (both `text-variable-anchor` and `text-radial-offset` are the parts of the variable text placement feature). * fix #8411, fetch in case of cache error (#8415) (#8417) * fix #8411, fetch in case of cache error * Use warnOnce * v1.1.0 & [email protected] (#8408) * Update style-spec version & changelog for [email protected] - Update style-spec/CHANGELOG.md to add bugfix items - Bump style-spec/package.json version to 13.7.1 (patch) * Update mapbox-gl package version to 1.1.0 for final release * Add missing style-spec changelog entry * Fix yarn.lock not installing under CI by auto-updating dependencies * manually strip urls for faster cache matching (#8434) (#8449) * update examples to use mapbox-gl-geocoder v4.4.1 (#8451) * set antialias to true for custom layers and extrusion examples (#8474) * swap map-tiles example to use https (#8482) * fix race condition between caching and aborting (#8472) fix #8470, continuous memory usage growth * fix #8481, unbounded memory growth in IE (#8490) Cancellable requests to workers should never call back after they have been cancelled. * v1.1.1 * [docs] fix SDK support for symbol-sort-key (#8501)
Launch Checklist
This PR removes the example https://docs.mapbox.com/mapbox-gl-js/example/map-tiles/ since it's using a classic style. The path will redirect to https://docs.mapbox.com/mapbox-gl-js/example/satellite-map/