Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tooltip to FullscreenControl #8012

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Add a tooltip to FullscreenControl #8012

merged 2 commits into from
Mar 13, 2019

Conversation

dmytro-gokun
Copy link
Contributor

As described in this feature proposal: #8009

@dmytro-gokun
Copy link
Contributor Author

This is my first experience with open source, so it might be a stupid question to ask.. Is there any additional step(s) I have to take before this can be merged?

@andrewharvey andrewharvey merged commit dfead0f into mapbox:master Mar 13, 2019
@dmytro-gokun dmytro-gokun mentioned this pull request Mar 13, 2019
Closed
@dmytro-gokun
Copy link
Contributor Author

@andrewharvey Thanks a lot for merging!

@andrewharvey
Copy link
Collaborator

Thanks for the PR. I think sometimes it won't be merged straight away just to given other contributors a chance to chime in with any comments before being merged.

@dmytro-gokun
Copy link
Contributor Author

Gotcha. It's just not very clear when you do it for the first time. But now i understand that sometimes i just need to wait :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewharvey andrewharvey andrewharvey approved these changes

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmytro-gokun @andrewharvey @mourner