Use account information instead of access token for local storage #7703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLoer
reviewed
Jan 2, 2019
ChrisLoer
reviewed
Jan 2, 2019
| if (isLocalStorageAvailable) { | ||
| try { | ||
| window.localStorage.setItem(uuidKey, this.anonId); | ||
| if (this.eventData.lastSuccess) { | ||
| if (Object.keys(this.eventData).length >= 1) { |
There was a problem hiding this comment.
Why is this change here? Isn't lastSuccess still set in the same place?
There was a problem hiding this comment.
It is unrelated, but it ensures that state is saved even if it doesn't include lastSuccess
ChrisLoer
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Closes #7602
Access tokens are not always permanent and some apps may rotate tokens quite frequently. In these cases the turnstile event is being sent more frequently than is necessary, and access token based local storage is being polluted.
This PR changes the way the turnstile event is triggered, and it's information stored, by basing it on the account owner instead of the encoded token.
cc @mick @amyjin7