Add abs, round, floor, ceil operators #6496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc @samanpwbb |
added 2 commits
April 10, 2018 20:56
anandthakker
pushed a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Apr 11, 2018
jfirebaugh
approved these changes
Apr 11, 2018
| 'abs': [ | ||
| NumberType, | ||
| [NumberType], | ||
| (ctx, args) => Math.abs(args[0].evaluate(ctx)) |
There was a problem hiding this comment.
Prefer argument destructuring as in the other definitions, i.e. (ctx, [n]) => ....
src/style-spec/reference/v8.json
Outdated
| @@ -2490,6 +2490,42 @@ | |||
| } | |||
| } | |||
| }, | |||
| "round": { | |||
| "doc": "Rounds the input to the nearest integer. Halflway values are rounded away from zero. E.g., `[\"round\", -1.5]` evaluates to -2.", | |||
1ec5
reviewed
Apr 11, 2018
src/style-spec/reference/v8.json
Outdated
| @@ -2490,6 +2490,42 @@ | |||
| } | |||
| } | |||
| }, | |||
| "round": { | |||
| "doc": "Rounds the input to the nearest integer. Halflway values are rounded away from zero. E.g., `[\"round\", -1.5]` evaluates to -2.", | |||
There was a problem hiding this comment.
Nit: It’s somewhat unusual to begin a sentence with “E.g.” “For example” is more easily understood.
tobrun
reviewed
Apr 11, 2018
| } | ||
| }, | ||
| "abs": { | ||
| "doc": "Returns the absolute value of the input.", |
There was a problem hiding this comment.
when implementing I noticed abs on -1.1 returns 1, could we include in the documentation that abs is an integer type function/not floating point? (from a java background this was a bit confusing for me).
There was a problem hiding this comment.
capturing from chat that above assumption was invalid
|
Oh shoot, that’s a bug! Will fix
…On Wed, Apr 11, 2018 at 7:25 AM Tobrun ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/style-spec/reference/v8.json
<#6496 (comment)>:
> @@ -2490,6 +2490,42 @@
}
}
},
+ "round": {
+ "doc": "Rounds the input to the nearest integer. Halflway values are rounded away from zero. E.g., `[\"round\", -1.5]` evaluates to -2.",
+ "group": "Math",
+ "sdk-support": {
+ "basic functionality": {
+ "js": "0.45.0"
+ }
+ }
+ },
+ "abs": {
+ "doc": "Returns the absolute value of the input.",
when implementing I noticed abs on -1.1 returns 1, could we include in
the documentation that abs is an integer type function/not floating point?
(from a java background this was a bit confusing for me).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6496 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvmR5Sn8Yyk5PGGKqZLchiFC6QChRzzks5tnegwgaJpZM4TPMfA>
.
|
added 2 commits
April 11, 2018 08:05
anandthakker
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Apr 11, 2018
* Add abs, round, floor, ceil operators Port of mapbox/mapbox-gl-js#6496 * [ios, macos] Simplified abs, ceiling, floor expressions * [ios, macos] Added rounding expression function * [android] - binding integration for round, ceil, floor and abs expressions * Update mapbox-gl-js to include non-integer rounding test * Drop extra braces * mapbox-gl-js -> master * Update style-spec docs -> PropertyFactory.java
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #5853
TODO: