Remove fast-stable-stringify #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
approved these changes
Aug 16, 2017
src/style-spec/group_by_layout.js
Outdated
| })); | ||
| function stringify(obj) { | ||
| const type = typeof obj; | ||
| if (type === 'number' || type === 'string' || type === 'undefined') |
mourner
force-pushed
the
remove-stable-stringify
branch
from
7137551 to
a9c76c6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5152 by implementing a simpler key generation for layer specifications. Input is pre-validated so we don't have to worry about circular links or weird objects, and the output doesn't have to be valid JSON, just good enough to be used as a unique key.
Launch Checklist
write tests for all new functionalitycovered bygroup_by_layout.test.js